CVE-2023-30542
GovernorCompatibilityBravo may trim proposal calldata
Impact
### Impact The proposal creation entrypoint (`propose`) in `GovernorCompatibilityBravo` allows the creation of proposals with a `signatures` array shorter than the `calldatas` array. This causes the additional elements of the latter to be ignored, and if the proposal succeeds the corresponding actions would eventually execute without any calldata. The `ProposalCreated` event correctly represents what will eventually execute, but the proposal parameters as queried through `getActions` appear to respect the original intended calldata. ### Patches This issue has been patched in v4.8.3. ### Workarounds Ensure that all proposals that pass through governance have equal length `signatures` and `calldatas` parameters.
Affected packages
| Ecosystem | Package | Affected | Fixed in |
|---|---|---|---|
| npm | @openzeppelin/contracts | >= 4.3.0, < 4.8.3 | 4.8.3 |
| npm | @openzeppelin/contracts-upgradeable | >= 4.3.0, < 4.8.3 | 4.8.3 |
Affected products
| Vendor | Product | Affected versions |
|---|---|---|
| Openzeppelin | Contracts | from 4.3.0 before 4.8.3 |
| Openzeppelin | Contracts Upgradeable | from 4.3.0 before 4.8.3 |
Weakness classification
References
- NVD record
- CVE.org record
- GitHub advisory
- https://github.com/OpenZeppelin/openzeppelin-contracts/releases/tag/v4.8.3
- https://github.com/OpenZeppelin/openzeppelin-contracts/security/advisories/GHSA-93hq-5wgc-jc82
- https://github.com/advisories/GHSA-93hq-5wgc-jc82
- https://nvd.nist.gov/vuln/detail/CVE-2023-30542
- https://github.com/OpenZeppelin/openzeppelin-contracts/commit/8d633cb7d169f2f8595b273660b00b69e845c2fe