CVE-2023-50728
Unauthenticated Denial of Service in the octokit/webhooks library
Impact
### Impact Versions [v9.26.0](https://github.com/octokit/webhooks.js/releases/tag/v9.26.0), [v10.9.x](https://github.com/octokit/webhooks.js/releases/tag/v10.9.1)), [v11.1.x](https://github.com/octokit/webhooks.js/releases/tag/v11.1.1), [v12.0.x](https://github.com/octokit/webhooks.js/releases/tag/v12.0.3) all contained the code that would throw the error. Specifically, during a pentest we encountered a bug in the octokit/webhooks library (a dependency of Probot, a framework for building Github Apps). The resulting request was found to cause an uncaught exception that ends the nodejs process. The problem is caused by an issue with error handling in the @octokit/webhooks library because the error can be undefined in some cases. Credit goes to @pb82 (for the early analysis) and @rh-tguittet (for discovery). ### Patches Maintenance releases for the Error being thrown by the verify method in [octokit/webhooks.js](https://github.com/octokit/webhooks.js) * v12 - [v12.0.4](https://github.com/octokit/webhooks.js/releases/tag/v12.0.4) * v11 - [v11.1.2](https://github.com/octokit/webhooks.js/releases/tag/v11.1.2) * v10 -[v10.9.2](https://github.com/octokit/webhooks.js/releases/tag/v10.9.2) * v9 - [v9.26.3](https://github.com/octokit/webhooks.js/releases/tag/v9.26.3) Maintenance release for the reference for [octokit/webhooks.js](https://github.com/octokit/webhooks.js) in [app.js](https://github.com/octokit/app.js) * [v14.0.2](https://github.com/octokit/app.js/releases/tag/v14.0.2) Maintenance release for the reference for [octokit/webhooks.js](https://github.com/octokit/webhooks.js) in [octokit.js](https://github.com/octokit/octokit.js) * [v3.1.2](https://github.com/octokit/octokit.js/releases/tag/v3.1.2) Maintenance release for the reference for [octokit/webhooks.js](https://github.com/octokit/webhooks.js) in [Protobot](https://github.com/probot/probot) * [v12.3.3](https://github.com/probot/probot/releases/tag/v12.3.3) ### Workarounds It is recommend that all users upgrade to the latest version of [octokit/webhooks.js](https://github.com/octokit/webhooks.js) or use one of the updated back ported versions.
Affected packages
| Ecosystem | Package | Affected | Fixed in |
|---|---|---|---|
| npm | @octokit/webhooks | < 9.26.3 | 9.26.3 |
| npm | @octokit/app | = 14.0.1 | 14.0.2 |
| npm | octokit | < 3.1.2 | 3.1.2 |
| npm | probot | < 12.3.3 | 12.3.3 |
Affected products
| Vendor | Product | Affected versions |
|---|---|---|
| Octokit | App | Version 14.0.1 |
| Octokit | Octokit | before 3.1.2 |
| Octokit | Webhooks | before 9.26.3 from 10.0.0 before 10.9.2 from 11.0.0 before 11.1.2 from 12.0.0 before 12.0.4 |
| Probot | Probot | before 12.3.3 |
Weakness classification
References
- NVD record
- CVE.org record
- GitHub advisory
- https://github.com/octokit/app.js/releases/tag/v14.0.2
- https://github.com/octokit/octokit.js/releases/tag/v3.1.2
- https://github.com/octokit/webhooks.js/releases/tag/v10.9.2
- https://github.com/octokit/webhooks.js/releases/tag/v11.1.2
- https://github.com/octokit/webhooks.js/releases/tag/v12.0.4
- https://github.com/octokit/webhooks.js/releases/tag/v9.26.3
- https://github.com/octokit/webhooks.js/security/advisories/GHSA-pwfr-8pq7-x9qv
- https://github.com/probot/probot/releases/tag/v12.3.3
- https://github.com/advisories/GHSA-pwfr-8pq7-x9qv
- https://nvd.nist.gov/vuln/detail/CVE-2023-50728