NetSight
critical9.8No CVE yet

GHSA-7vw7-qx38-37vr

Propel2 SQL injection possible with limit() on MySQL

Impact

The limit() query method is susceptible to catastrophic SQL injection with MySQL. For example, given a model User for a table users: ``` UserQuery::create()->limit('1;DROP TABLE users')->find(); ``` This will drop the users table! The cause appears to be a lack of integer casting of the limit input in either Propel\Runtime\ActiveQuery\Criteria::setLimit() or in Propel\Runtime\Adapter\Pdo\MysqlAdapter::applyLimit(). The code comments there seem to imply that casting was avoided due to overflow issues with 32-bit integers. This is surprising behavior since one of the primary purposes of an ORM is to prevent basic SQL injection. This affects all versions of Propel: 1.x, 2.x, and 3.

An attacker can exploit this over the network, without logging in, without any action by a user. If it succeeds: high risk of data being read, high risk of data or systems being changed, high risk of outages.

Affected packages

EcosystemPackageAffectedFixed in
composerpropel/propel>= 2.0.0-alpha1, <= 2.0.0-alpha72.0.0-alpha8

Weakness classification

References